fix: error handling and add TS types Sebbe PR #280 with refactor #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Dawntraoz
commented
Feb 3, 2023
Dawntraoz
commented
- Adds typed return, typed state, and params by @SebbeJohansson fix: error handling and add TS types #280 close useAsyncStoryblok result is not typed #256
- Add error handling suggested at Throw 404 error if story was not found #267
- Remove async await from the call (not needed at all)
This was referenced Feb 3, 2023
Closed
|
🕺 |
alvarosabu
reviewed
Feb 3, 2023
fgiuliani
approved these changes
Feb 3, 2023
alvarosabu
approved these changes
Feb 6, 2023
|
Glad we could figure out an amazing solution together 🥳 |
|
Such a nice community we are building @SebbeJohansson 💜 |
|
🎉 This PR is included in version 5.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.